Skip to content

Fix TPU tests, removed test exclusion mechanism.#22571

Merged
hertschuh merged 1 commit intokeras-team:masterfrom
hertschuh:tpu_tests
Apr 3, 2026
Merged

Fix TPU tests, removed test exclusion mechanism.#22571
hertschuh merged 1 commit intokeras-team:masterfrom
hertschuh:tpu_tests

Conversation

@hertschuh
Copy link
Copy Markdown
Collaborator

@hertschuh hertschuh commented Mar 27, 2026

  • Remove the file-based exclusion mechanism as it is no longer needed.
  • jax2onnx fixed the ONNX export on TPU.
  • tf_save_model export works on TPU, simply, the native_serialization_platforms argument has to be passed to also export to CPU as the reloading happens with a CPU only version of TensorFlow.
  • Only conv transpose tests remain excluded.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.29%. Comparing base (9708582) to head (d2b101a).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #22571   +/-   ##
=======================================
  Coverage   83.29%   83.29%           
=======================================
  Files         596      596           
  Lines       68138    68138           
  Branches    10613    10613           
=======================================
  Hits        56754    56754           
  Misses       8638     8638           
  Partials     2746     2746           
Flag Coverage Δ
keras 83.10% <ø> (ø)
keras-jax 59.66% <ø> (ø)
keras-numpy 55.33% <ø> (ø)
keras-openvino 53.38% <ø> (ø)
keras-tensorflow 61.03% <ø> (ø)
keras-torch 59.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request re-enables a large suite of JAX TPU tests by removing them from the exclusion list. Feedback was provided to add a missing trailing newline to the exclusion file for better compatibility with standard tools.

@keerthanakadiri
Copy link
Copy Markdown
Contributor

Code Review

This pull request re-enables a large suite of JAX TPU tests by removing them from the exclusion list. Feedback was provided to add a missing trailing newline to the exclusion file for better compatibility with standard tools.

@hertschuh

@hertschuh hertschuh force-pushed the tpu_tests branch 3 times, most recently from 75432d8 to e7af66d Compare April 2, 2026 19:35
@hertschuh hertschuh changed the title Fix some TPU tests. Fix TPU tests, removed test exclusion mechanism. Apr 2, 2026
- Remove the file-based exclusion mechanism as it is no longer needed.
- `jax2onnx` fixed the ONNX export on TPU.
- tf_save_model export works on TPU, simply, the `native_serialization_platforms` argument has to be passed to also export to CPU as the reloading happens with a CPU only version of TensorFlow.
- Only conv transpose tests remain excluded.
@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Apr 3, 2026
@hertschuh hertschuh merged commit cccbefd into keras-team:master Apr 3, 2026
14 checks passed
@hertschuh hertschuh deleted the tpu_tests branch April 3, 2026 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kokoro:force-run ready to pull Ready to be merged into the codebase size:M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants